Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListboxInput]: Update submit button querySelector specificity #903

Merged
merged 8 commits into from Apr 20, 2022

Conversation

jeffgrannes
Copy link
Contributor

@jeffgrannes jeffgrannes commented Jan 26, 2022

Hello, our website has a Listbox within a form. When we press enter on the Listbox, it is currently clicking the first button that it finds on the page and not our submit button. This PR updates the specificity of the selector to select the first button without a type or the first item with type=submit.

Thank you!

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.
  • Add documentation to support any new features.

This pull request:

If creating a new package:

  • Make sure the new package directory contains each of the following, and that their structure/formatting mirrors other related examples in the project:
    • examples directory
    • src directory with an index.tsx entry file
    • At least one example file per feature introduced by the new package
    • Base styles in a style.css file (if needed by the new package)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 26, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed8795a:

Sandbox Source
reach-ui-template Configuration

@jeffgrannes jeffgrannes changed the title Update submit button querySelector specificity Listbox: Update submit button querySelector specificity Jan 27, 2022
@jeffgrannes jeffgrannes changed the title Listbox: Update submit button querySelector specificity [Listbox]: Update submit button querySelector specificity Jan 27, 2022
@jeffgrannes jeffgrannes marked this pull request as ready for review February 1, 2022 17:59
@jeffgrannes jeffgrannes changed the title [Listbox]: Update submit button querySelector specificity [ListboxInput]: Update submit button querySelector specificity Feb 2, 2022
@ccveer
Copy link

ccveer commented Feb 16, 2022

@chaance, could you take a look at this? We need this change in order to pass our a11y compliance audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants