Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cross-platform binary/script #4

Closed
amaury1093 opened this issue Aug 29, 2018 · 3 comments
Closed

Create cross-platform binary/script #4

amaury1093 opened this issue Aug 29, 2018 · 3 comments

Comments

@amaury1093
Copy link
Member

amaury1093 commented Aug 29, 2018

Right now this is only a script, which only works on *nix systems. It'd be wise to rewrite this in another language, which can be run on different platforms.

@hadisfr
Copy link
Contributor

hadisfr commented Sep 3, 2018

What do you mean by binary exactly? 🤔 Is a python port of this script good enough?
And… rewrite in another language would be another project. Or you want to add another implementation next to the current one in the same repo?

@amaury1093 amaury1093 changed the title Create a binary Create cross-platform binary/script Sep 4, 2018
@amaury1093
Copy link
Member Author

amaury1093 commented Sep 4, 2018

Right, a python port would definitely work, I changed the title.

I wish to improve on this implementation. One improvement would be to parallelize the telnet calls so that it resolves faster, afaik bash doesn't support threads. Another improvement would be for it to work on all platforms.

We can keep the bash version in another folder in the same repo (if people want that), but I think the main program should be rewritten in a more advanced language.

I actually started writing a Rust port on the am-rust branch, but if you're interested in writing a python version I'd be happy to drop my branch and accept yours.

@hadisfr
Copy link
Contributor

hadisfr commented Sep 4, 2018

Actually, I don't how how much free time I've got right now. If I write any script, I'll tell you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants