fix: split Microsoft 365/Hotmail functionality #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hotmail` was previously behind the `headless` feature which, if disabled, breaks the Microsoft 365 API functionality. refactor these into a `microsoft` module, leaving the `hotmail` module behind the `headless` feature and allowing the Microsoft 365 API to exist separately.
amaury1093
reviewed
Oct 12, 2022
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
juhniorsantos
pushed a commit
to juhniorsantos/check-if-email-exists
that referenced
this pull request
Apr 11, 2024
* fix: split Microsoft 365/Hotmail functionality `hotmail` was previously behind the `headless` feature which, if disabled, breaks the Microsoft 365 API functionality. refactor these into a `microsoft` module, leaving the `hotmail` module behind the `headless` feature and allowing the Microsoft 365 API to exist separately. * fix: explanation of Microsoft365Error Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotmailwas previously behind theheadlessfeature which, if disabled, breaks the Microsoft 365 API functionality.refactor these into a
microsoftmodule, leaving thehotmailmodule behind theheadlessfeature and allowing the Microsoft 365 API to exist separately.fixes #1203
I've verified that the Microsoft 365 API behaviour is still working in all previously-tested scenarios.
Someone more familiar with the Hotmail
headlessfeature might want to put that through its paces though…?