Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEasy React-based input bindings #22
Conversation
Remove trailing whitespace
|
@timelyportfolio I think this is in good enough shape for you to play around with now. Thanks in advance for any feedback! I hope to rope in @jcheng5 for a code review this week too. I'll collect feedback from you both and then let you know when things are in a merge-worthy state. |
|
@alandipert I got a chance to walk through the vignette from scratch, and everything worked nicely. I will try to walk through with a completely new and different component now. I think we should add |
|
@timelyportfolio thanks as always for the close review. I'm happy to make these changes. I got sidetracked this week helping with a Shiny release but I should be able to work on this tomorrow. I'll also have a very small change I'll push soon that restricts the |
|
@timelyportfolio OK, all changes are in |
|
thanks @alandipert !!!! merged!!! |
input binding support
This adds a new scaffolding function,
scaffoldReactShinyInput, for scaffolding new inputs based on React. It also adds:reactR.reactShinyInput, for registering React components as Shiny inputscreateReactShinyInput, for constructing inputs with custom configuration and a default value on the R side.In addition to the new scaffold function, existing scaffold code was extensively reworked. Scaffold functionality common between the widget and input scaffold functions were factored into helper functions.