New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compliance with the new htmlwidgets convention #49

Merged

timelyportfolio merged 2 commits into react-R:master from stla:widget_html

Feb 16, 2021

Contributor

stla commented Dec 23, 2020

From the htmlwidgets 1.5.3 NEWS:

Support a new PACKAGE::widget_html.WIDGETNAME convention for defining custom widget HTML. This replaces the earlier PACKAGE::WIDGETNAME_html convention, which continues to work but may be deprecated at some point in the future. The goal for the new convention is to prevent accidentally matching functions that were never intended for this purpose.


          compliance with the new htmlwidgets convention

dcd3fcd

timelyportfolio mentioned this pull request

allow import "path/style.css" inside jsx (update webpack.config.js bo… #50

Merged

Collaborator

timelyportfolio commented Feb 16, 2021

Thanks so much for this contribution @stla. I'll test and plan to merge soon. I will also update DESCRIPTION to require latest htmlwidgets.


          Merge branch 'master' into widget_html

9098b9c

timelyportfolio merged commit eef5d04 into react-R:master

timelyportfolio mentioned this pull request

update react to 17.0.0 and prepare for CRAN #51

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment