Merge 2405fa9 into 9176592

react-boilerplate · Oct 27, 2020 · 487ad33 · 487ad33
2 parents 9176592 + 2405fa9
commit 487ad33
Show file tree

Hide file tree

Showing 10 changed files with 18,584 additions and 11,384 deletions.
diff --git a/internals/startingTemplate/tsconfig.json b/internals/startingTemplate/tsconfig.json
@@ -14,6 +14,7 @@
     "resolveJsonModule": true,
     "isolatedModules": true,
     "noEmit": true,
+    "noFallthroughCasesInSwitch": true,
     "jsx": "react",
     "baseUrl": "./src"
   },

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -148,7 +148,7 @@
     "node-plop": "0.25.0",
     "plop": "2.6.0",
     "prettier": "2.0.1",
-    "react-scripts": "3.4.1",
+    "react-scripts": "4.0.0",
     "react-test-renderer": "16.13.0",
     "replace-in-file": "6.0.0",
     "rimraf": "3.0.2",

diff --git a/src/app/__tests__/__snapshots__/index.test.tsx.snap b/src/app/__tests__/__snapshots__/index.test.tsx.snap
@@ -23,6 +23,6 @@ exports[`<App /> should render and match the snapshot 1`] = `
       component={[Function]}
     />
   </Switch>
-  <UNDEFINED />
+  <Memo(GlobalStyleComponent) />
 </BrowserRouter>
 `;
diff --git a/src/app/containers/GithubRepoForm/index.tsx b/src/app/containers/GithubRepoForm/index.tsx
@@ -34,6 +34,7 @@ export function GithubRepoForm() {
   };
 
   const useEffectOnMount = (effect: React.EffectCallback) => {
+    // eslint-disable-next-line react-hooks/exhaustive-deps
     useEffect(effect, []);
   };
   useEffectOnMount(() => {