Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(internals): Upgrade enzyme to v3 #1966

Merged
merged 5 commits into from
Dec 16, 2017
Merged

chore(internals): Upgrade enzyme to v3 #1966

merged 5 commits into from
Dec 16, 2017

Conversation

timburgess
Copy link

@timburgess timburgess commented Oct 7, 2017 •
edited by justingreenberg
Loading

Upgrade to Enzyme 3

This resolves what I believe to be the major blocker for React 16

  • Upgrades enzyme to 3.1.0 and the required enzyme adapter (React 15 for now)
  • Adapter setup for tests
  • Resolves some syntax issues for some tests
  • Deal with different find behaviour for new static renderer

Resolves #1950

@coveralls
Copy link

coveralls commented Oct 7, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6a83eea on timburgess:upgrade-enzyme into 53be21a on react-boilerplate:dev.

justingreenberg
justingreenberg approved these changes Oct 7, 2017
View reviewed changes
Copy link
Member

@justingreenberg justingreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this is awesome! solid start for #1950

looks to have no effect on templates, so LGTM 👍

@justingreenberg justingreenberg changed the title #1950 - Upgrade enzyme. Setup adapter. Correct syntax for tests. chore(internals): Upgrade enzyme to v3 Oct 7, 2017
@justingreenberg justingreenberg added this to the v3.6 milestone Oct 7, 2017
@coveralls
Copy link

coveralls commented Oct 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3bba1c8 on timburgess:upgrade-enzyme into cec0dfc on react-boilerplate:dev.

@coveralls
Copy link

coveralls commented Oct 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e2c4e1e on timburgess:upgrade-enzyme into 5083372 on react-boilerplate:dev.

@coveralls
Copy link

coveralls commented Oct 28, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e2edc41 on timburgess:upgrade-enzyme into edd72c8 on react-boilerplate:dev.

@blling blling mentioned this pull request Dec 16, 2017
Closed
9 tasks
blling
blling suggested changes Dec 16, 2017
View reviewed changes
Copy link

@blling blling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update enzyme to the lastest version and use enzyme-adapter-react-16 instead of enzyme-adapter-react-15

package.json
@@ -264,7 +265,8 @@
"circular-dependency-plugin": "3.0.0",
"coveralls": "2.13.1",
"css-loader": "0.28.4",
"enzyme": "2.8.2",
"enzyme": "3.1.0",
"enzyme-adapter-react-15": "1.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use enzyme-adapter-react-16 instead of enzyme-adapter-react-15

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En, I am sorry, Maybe should do this in a follow up PR.

@coveralls
Copy link

coveralls commented Dec 16, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 928e883 on timburgess:upgrade-enzyme into af6b322 on react-boilerplate:dev.

@blling blling merged commit 3d18255 into react-boilerplate:dev Dec 16, 2017
@PaulLaux PaulLaux mentioned this pull request Jan 22, 2018
Open
@lock
Copy link

lock bot commented May 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justingreenberg justingreenberg justingreenberg approved these changes

@blling blling blling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timburgess @coveralls @justingreenberg @blling