Feature/add styles const #2143
Merged
Feature/add styles const #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on #2073 Adds a new docs page about setting up your editor. This page specifically documents creating a `jsconfig.json` to improve the editing experinace with VS Code
|
Switched base branch to styles/rfc. I did not switch to SCREAMING_SNAKE, however if that's the preferred method I can! Sorry about the week delay on this. |
1 similar comment
|
Nice! Thanks for this. We'll see if we can generate some discussion |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2115
I'd like to leave discussion of the idea itself to the issue (which is an RFC). If approved, this will be my first contribution to react-boilerplate. I'm happy to take all pointers and address all concerns.
Accidentally closed the last PR when I deleted the branch on my fork, sorry about that. You can view that discussion here.
@gretzky @avdeev