New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SSR example to docs #2306
add SSR example to docs #2306
Conversation
Should the PR be merged to dev, then to master, or is dev in an unknown state? (Trying to get back up-to-speed as I've been away a while) |
Dev is, I think (correct me if wrong @julienben) in a good state. I figured a minor doc change to master regarding SSR wouldn't hurt since we get asked about it pretty often 😅 And welcome back, @jwinn! |
I don't disagree with it going into master. I was under the impression that we wanted My initial impetus for the query, though, was I wasn't sure on the state of |
@jwinn We do have a clean dev branch now. @gretzky I think a link in the TOC is a bit confusing. People click there expecting to remain on the same page, not be taken to a different repo. Could the TOC item link instead to a short paragraph in README.md which briefly explains your SSR project and links to the repo from there? About merging this directly to master: Fine by me so long as we rebase dev on top of master right away to keep the history clean. Alternatively, we could merge this into dev and do a small 3.6.1 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeat of last comment: I think a link in the TOC is a bit confusing. People click there expecting to remain on the same page, not be taken to a different repo. Could the TOC item link instead to a short paragraph in README.md which briefly explains your SSR project and links to the repo from there?
Closing in favor of #2372. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
super quick/easy change. i added an SSR example to the table of contents so its right there if anyone goes looking for it.