Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SSR example to docs #2306

Closed
wants to merge 2 commits into from
Closed

add SSR example to docs #2306

wants to merge 2 commits into from

Conversation

gretzky
Copy link
Member

@gretzky gretzky commented Aug 5, 2018

super quick/easy change. i added an SSR example to the table of contents so its right there if anyone goes looking for it.

@gretzky gretzky requested a review from julienben August 5, 2018 22:41
@coveralls
Copy link

coveralls commented Aug 5, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling aecf305 on add-ssr-example into fc4dc29 on dev.

@jwinn
Copy link
Collaborator

jwinn commented Aug 5, 2018

Should the PR be merged to dev, then to master, or is dev in an unknown state? (Trying to get back up-to-speed as I've been away a while)

@gretzky
Copy link
Member Author

gretzky commented Aug 6, 2018

Dev is, I think (correct me if wrong @julienben) in a good state. I figured a minor doc change to master regarding SSR wouldn't hurt since we get asked about it pretty often 😅

And welcome back, @jwinn!

@jwinn
Copy link
Collaborator

jwinn commented Aug 6, 2018

I don't disagree with it going into master. I was under the impression that we wanted dev to be in-sync and ahead of master. So the process was: changes are made to dev, then propagated to master, with any semantic version and changelog updates, where required, made as well--in this case being unnecessary.

My initial impetus for the query, though, was I wasn't sure on the state of dev--believing it in a good state, but I wasn't completely sure and wanted to verify. Are we still using gitter to have these kinds of discussions, or is there somewhere else we can chat? 😄

@julienben
Copy link
Member

@jwinn We do have a clean dev branch now.

@gretzky I think a link in the TOC is a bit confusing. People click there expecting to remain on the same page, not be taken to a different repo. Could the TOC item link instead to a short paragraph in README.md which briefly explains your SSR project and links to the repo from there?

About merging this directly to master: Fine by me so long as we rebase dev on top of master right away to keep the history clean. Alternatively, we could merge this into dev and do a small 3.6.1 release.

Copy link
Member

@julienben julienben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeat of last comment: I think a link in the TOC is a bit confusing. People click there expecting to remain on the same page, not be taken to a different repo. Could the TOC item link instead to a short paragraph in README.md which briefly explains your SSR project and links to the repo from there?

@julienben
Copy link
Member

It might also be the perfect opportunity to add a link to @mjangir's electron version of RBP (#2288)

@julienben julienben changed the base branch from master to dev August 30, 2018 07:31
@julienben
Copy link
Member

Closing in favor of #2372.

@julienben julienben closed this Oct 9, 2018
@julienben julienben deleted the add-ssr-example branch October 9, 2018 10:37
@lock
Copy link

lock bot commented Nov 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants