Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constructor instead of cWillMount for correct injection order #2468

Merged
merged 1 commit into from Nov 15, 2018

Conversation

julienben
Copy link
Member

React Boilerplate

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues

Changelog

This is an alternative to @tonyex52's fix for #2314 in his PR #2467.

Instead of making injection Promise-based (which has a few drawbacks not addressed in #2467), we simply do the injection from the constructor.

It'll guarantee that things happen in the correct order, as described by @flameddd in #2314.

All tests are passing with no changes required.

I also did the same thing for reducer injection, if only for consistency.

Also, a small doc update that was missed when we switched the default saga injection mode to DAEMON.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f08dace on saga-injection-fix into 75dd475 on dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f08dace on saga-injection-fix into 75dd475 on dev.

@lock
Copy link

lock bot commented Dec 15, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants