Use constructor instead of cWillMount for correct injection order #2468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Boilerplate
dev
and targetsdev
Changelog
This is an alternative to @tonyex52's fix for #2314 in his PR #2467.
Instead of making injection Promise-based (which has a few drawbacks not addressed in #2467), we simply do the injection from the constructor.
It'll guarantee that things happen in the correct order, as described by @flameddd in #2314.
All tests are passing with no changes required.
I also did the same thing for reducer injection, if only for consistency.
Also, a small doc update that was missed when we switched the default saga injection mode to DAEMON.