Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(style): inline animation interpolation #2481

Merged
merged 1 commit into from Nov 20, 2018
Merged

fix(style): inline animation interpolation #2481

merged 1 commit into from Nov 20, 2018

Conversation

jwinn
Copy link
Collaborator

@jwinn jwinn commented Nov 20, 2018

fix failing style-lint for LoadingIndicator/Circle by removing css fn call and inlining the interpolated piece
re-add npm run lint:css to lint script in package.json

@jwinn jwinn requested a review from julienben November 20, 2018 21:58
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3b1743c on fix/style-lint into 66fcdc5 on dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3b1743c on fix/style-lint into 66fcdc5 on dev.

@gretzky gretzky self-requested a review November 20, 2018 23:22
gretzky
gretzky approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@gretzky gretzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@gretzky gretzky merged commit fb6d51a into dev Nov 20, 2018
@jwinn jwinn deleted the fix/style-lint branch November 20, 2018 23:24
@lock
Copy link

lock bot commented Dec 20, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gretzky gretzky gretzky approved these changes

@julienben julienben Awaiting requested review from julienben julienben is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwinn @coveralls @gretzky