Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue template and issue-close-app #2500

Merged
merged 1 commit into from Nov 27, 2018
Merged

Conversation

julienben
Copy link
Member

I think these changes would allow us to turn the issue close bot back on. Do you agree?

(I removed the mention of package.json because I'm assuming most users overwrite the version when starting to build their own apps. In fact, we probably ought to set it to 0.1.0 or something similar in the setup script.)

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 65cd96c on update-close-issue-bot into 72a2efd on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 65cd96c on update-close-issue-bot into 72a2efd on master.

Copy link
Member

@gretzky gretzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@gretzky gretzky merged commit b136b0c into master Nov 27, 2018
@julienben julienben deleted the update-close-issue-bot branch November 27, 2018 17:07
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants