Offer offline support using workbox #2772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omrimor
requested review from
gretzky,
julienben,
justingreenberg,
jwinn and
JohnMostlyR
as code owners
|
...did this ever get merged? Is there a branch available to use this version? |
|
Sorry @t3db0t, The feedback given suggested a different approach. Will take another swing at it and open a new PR |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues raised in this issue.
@julienben brought it up to my attention and I thought I'll have a go trying to resolve. (Full disclosure - Julien is a co-worker and my tech lead. 馃).
This PR removes the current
offline-pluginin favour of theworkbox-webpack-plugin.I follow the guidelines of
create-react-appand chose an opt-in approach.Open issues
[-] Missing tests - Will add once I get some feedback and see if the direction is good
[-] Documentation could be improved. Not a native english speaker so might need help
Will appreciate any feedback, comments and anything else that could be improved.
This is my first time contributing to OSS, so please be gentle with me 馃槃.
NOTE:
A similar branch was opened by me and closed since. This one is aligned with latest upstream dev