Maintenance #2819
Merged
Maintenance #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienben
requested review from
gretzky,
justingreenberg,
jwinn and
JohnMostlyR
as code owners
BenLorantfy
approved these changes
Nov 24, 2019
| @@ -10,22 +10,13 @@ const selectGlobal = state => state.global || initialState; | |||
| const selectRouter = state => state.router; | |||
|
|
|||
| const makeSelectCurrentUser = () => | |||
There was a problem hiding this comment.
As per #2806 (comment), do we want to change some of these selector factories to regular selectors?
There was a problem hiding this comment.
Yes it's in the to do list for #2812. The changes you see here are just because prettier wanted them.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Boilerplate
reactto v16.12 yet as@hot-loader/react-domis still on v16.11 but will make sure to do it before we release v5.0.I ran our full regression tests on this. Everything should be working.