Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Yarn package manager #2907

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Conversation

getspooky
Copy link

@getspooky getspooky commented Apr 26, 2020

React Boilerplate

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues

Description

The main reason why support Yarn package manager in react-boilerplate. In the case of npm, when we need to deploy the project on different machines, the versions of installed packages can be different.

  1. can install packages from the local cache
  2. strongly binds package versions
  3. allows parallel packages installation
  4. Yarn is its stability

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

@coveralls
Copy link

coveralls commented Apr 26, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 4eca6d6 on getspooky:dev into e9ed2b6 on react-boilerplate:dev.

@gretzky
Copy link
Member

gretzky commented Apr 29, 2020

Could you write in the PR description the purpose of this change / why this change is necessary?

@Can-Sahin
Copy link
Member

Can-Sahin commented Jul 3, 2020

Edit: Sorry I opening this back as a result of not merging the #2935 if that means anything;)

@Can-Sahin Can-Sahin closed this Jul 3, 2020
@Can-Sahin Can-Sahin reopened this Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants