Implement simplified selector pattern #2921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-victor
requested review from
gretzky,
julienben,
justingreenberg and
jwinn
as code owners
|
Hello @julienben ! I implemented this recommendation for myself (in my projects), opened this PR against your PR #2812 and fixed the build for Node 14 (PR #2812 was successful because it used Node 13 which didn't check for After all this, I found PR #2823. 😞 Please feel free to close this PR if it feels unnecessary. |
|
Duplicate of #2823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggestions made in this comment.