Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noDataIndication: doesn't account for hidden columns #185

Closed
fuchsberger opened this issue Jan 29, 2018 · 3 comments
Closed

noDataIndication: doesn't account for hidden columns #185

fuchsberger opened this issue Jan 29, 2018 · 3 comments

Comments

@fuchsberger
Copy link

A small visual inconsistency I found:

when a table is empty the default row with class 'react-bs-table-no-data' has a colspan for the total number of columns.
it should actually be the total number of columns minus hidden fields.

this solves some visual inconsistencies with column headers displaying incorrectly.
hope I don't get annoying :)

@AllenFang
Copy link
Member

@Sathras oh not annoying :)

so in this case you mention, you will see the wrong colspan size on table, right?

@AllenFang
Copy link
Member

I see, that's a bug lol

@AllenFang AllenFang added the bug label Jan 30, 2018
@AllenFang AllenFang added this to To Do in 20180202-sprint via automation Jan 30, 2018
@AllenFang AllenFang added this to the 20180202-sprint milestone Jan 30, 2018
20180202-sprint automation moved this from To Do to Done Feb 1, 2018
@AllenFang
Copy link
Member

@Sathras fixed on react-bootstrap-table-next@0.1.2, check release note: https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2018/02/02/version-bump.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants