Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes remote sorting issue #354

Merged
merged 1 commit into from
Jun 2, 2018
Merged

Fixes remote sorting issue #354

merged 1 commit into from
Jun 2, 2018

Conversation

amoludage
Copy link
Contributor

@amoludage amoludage commented May 28, 2018 •
edited

#335

  • when remote sort is true then disable client side sorting in componentWillReceivedProps method

fixes sorting issue
1b21283 
  + when remote sort is true then disable client side sorting
@AllenFang
Copy link
Member

@amoludage thanks you, I'll check it later and release in this week 👍

@AllenFang AllenFang self-requested a review May 28, 2018 13:26
@amoludage
Copy link
Contributor Author

@AllenFang can you please look into the PR.

@AllenFang AllenFang changed the base branch from master to develop June 2, 2018 05:20
@AllenFang AllenFang merged commit 68afc34 into react-bootstrap-table:develop Jun 2, 2018
@AllenFang AllenFang added this to To do in 20180604-sprint via automation Jun 2, 2018
@AllenFang AllenFang moved this from To do to Done in 20180604-sprint Jun 2, 2018
@AllenFang
Copy link
Member

released on react-bootstrap-table-next@0.1.13. thanks your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenFang AllenFang Awaiting requested review from AllenFang

Assignees
No one assigned
Labels
None yet
Projects
No open projects
20180604-sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amoludage @AllenFang