Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom pagination total #359

Merged
merged 3 commits into from
Jun 3, 2018
Merged

Adding custom pagination total #359

merged 3 commits into from
Jun 3, 2018

Conversation

sean-ww
Copy link
Contributor

@sean-ww sean-ww commented May 30, 2018

Putting back the ability to override the default pagination totals (like paginationShowsTotal in the original react-bootstrap-table).

@AllenFang
Copy link
Member

@sean-ww thanks, I will review it in this weekend 👍

@@ -66,6 +81,7 @@ const options = {
firstPageTitle: 'Next page',
lastPageTitle: 'Last page',
showTotal: true,
paginationTotal: customTotal,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sean-ww could you please change paginationTotal to paginationTotalRenderer? Thanks

@AllenFang AllenFang added this to To do in 20180604-sprint via automation Jun 3, 2018
Copy link
Member

@AllenFang AllenFang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllenFang AllenFang merged commit 2ff0b27 into react-bootstrap-table:develop Jun 3, 2018
20180604-sprint automation moved this from To do to Done Jun 3, 2018
@AllenFang
Copy link
Member

@sean-ww, thanks your contribution, will be released soon

@AllenFang
Copy link
Member

Released on react-bootstrap-table2-paginator@0.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants