Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-ultimate-pagination example #1

Closed
leviwheatcroft opened this issue Jan 5, 2018 · 1 comment
Closed

react-ultimate-pagination example #1

leviwheatcroft opened this issue Jan 5, 2018 · 1 comment

Comments

@leviwheatcroft
Copy link

This example is really helpful, but ITEM_TYPES.PAGE is missing onClick

should be something like this:

    [ITEM_TYPES.PAGE]: ({ value, isActive, onClick }) => (
      <Pagination.Item active={isActive} onClick={onClick}>{value}</Pagination.Item>
    ),
@jquense
Copy link
Member

jquense commented Jan 5, 2018

thanks care to send a PR?

boton added a commit to boton/pagination that referenced this issue Apr 12, 2018
@boton
Update README.md
fea3dac 
Add missing onClick in `ITEM_TYPES.PAGE`.

Fixes: react-bootstrap#1
@boton boton mentioned this issue Apr 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jquense @leviwheatcroft