Merge pull request #3350 from vojty/fix/validate-children-nav-keyboard

Nav: Validate children in keyboard navigation handler
react-bootstrap · Oct 25, 2018 · 357d3b7 · 357d3b7
2 parents 3360fde + 68909b3
commit 357d3b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Nav.js b/src/Nav.js
@@ -157,7 +157,8 @@ class Nav extends React.Component {
 
   getNextActiveChild(offset) {
     const { children } = this.props;
-    const validChildren = children.filter(
+    const validChildren = ValidComponentChildren.filter(
+      children,
       child => child.props.eventKey != null && !child.props.disabled
     );
     const { activeKey, activeHref } = this.getActiveProps();

diff --git a/test/NavSpec.js b/test/NavSpec.js
@@ -168,6 +168,7 @@ describe('<Nav>', () => {
             NavItem 4 content
           </NavItem>
           <NavItem eventKey={5}>NavItem 5 content</NavItem>
+          {false && <NavItem eventKey={6}>NavItem 6 content</NavItem>}
         </Nav>,
         { attachTo: mountPoint }
       );