Skip to content

Commit

Permalink
feat(v5): Set ColOrder types to max 5 (#5376)
Browse files Browse the repository at this point in the history
* feat(v5): Set ColOrder types to max 5

* Split col numbers into another type
  • Loading branch information
kyletsang committed Aug 12, 2020
1 parent d780b43 commit 926c7cf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Col.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ type NumberAttr =
| '11'
| '12';

type ColOrder = 'first' | 'last' | NumberAttr;
type ColOrderNumber = number | '1' | '2' | '3' | '4' | '5';
type ColOrder = ColOrderNumber | 'first' | 'last';
type ColSize = boolean | 'auto' | NumberAttr;
type ColSpec =
| ColSize
Expand Down
4 changes: 4 additions & 0 deletions www/src/pages/migrating.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ Below is a _rough_ account of the breaking API changes as well as the minimal ch

- removed `toggle`.

### Col

- `ColOrder` is now maximum 5 instead of 12.

### Form

- removed `inline`.
Expand Down

0 comments on commit 926c7cf

Please sign in to comment.