fix: fix TS error with transition types (#5610)

react-bootstrap · Feb 16, 2021 · bb84d81 · bb84d81
1 parent 53ce159
commit bb84d81
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/helpers.ts b/src/helpers.ts
@@ -69,6 +69,7 @@ export type TransitionComponent = React.ComponentType<
   {
     in?: boolean;
     appear?: boolean;
+    children: React.ReactElement;
   } & TransitionCallbacks
 >;
 

diff --git a/tests/simple-types-test.tsx b/tests/simple-types-test.tsx
@@ -55,12 +55,40 @@ const style: React.CSSProperties = {
   color: 'red',
 };
 
+class ClassComponent extends React.Component {
+  render() {
+    return <div>abc</div>;
+  }
+}
+
+const FunctionComponent: React.FC = () => {
+  return <div>abc</div>;
+};
+
 // eslint-disable-next-line @typescript-eslint/no-empty-function
 const noop = () => {};
 
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 const MegaComponent = () => (
   <>
+    <Fade>
+      <div>abc</div>
+    </Fade>
+    <Fade>
+      <ClassComponent />
+    </Fade>
+    <Fade>
+      <FunctionComponent />
+    </Fade>
+    <Collapse>
+      <div>abc</div>
+    </Collapse>
+    <Collapse>
+      <ClassComponent />
+    </Collapse>
+    <Collapse>
+      <FunctionComponent />
+    </Collapse>
     <Alert transition={Fade} />
     <Alert transition={Collapse} />
     <Alert