fix: navbar toggle correct 'collapsed' className when collapsed (#4412)

* Navbar toggle correct 'collapsed' className when collapsed * navbar spec updates
react-bootstrap · Sep 5, 2019 · bcb0c8e · bcb0c8e
1 parent 27c162f
commit bcb0c8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/NavbarToggle.js b/src/NavbarToggle.js
@@ -61,7 +61,7 @@ const NavbarToggle = React.forwardRef(
         ref={ref}
         onClick={handleClick}
         aria-label={label}
-        className={classNames(className, bsPrefix, !!expanded && 'collapsed')}
+        className={classNames(className, bsPrefix, !expanded && 'collapsed')}
       >
         {children || <span className={`${bsPrefix}-icon`} />}
       </Component>

diff --git a/test/NavbarSpec.js b/test/NavbarSpec.js
@@ -119,15 +119,15 @@ describe('<Navbar>', () => {
     let collapse = wrapper.find('Collapse');
 
     expect(collapse.is('[in=false]')).to.equal(true);
-    expect(toggle.hasClass('collapsed')).to.equal(false);
+    expect(toggle.hasClass('collapsed')).to.equal(true);
 
     toggle.simulate('click');
 
     toggle = wrapper.find('.navbar-toggler');
     collapse = wrapper.find('Collapse');
 
     expect(collapse.is('[in=true]')).to.equal(true);
-    expect(toggle.hasClass('collapsed')).to.equal(true);
+    expect(toggle.hasClass('collapsed')).to.equal(false);
   });
 
   it('Should open external href link in collapseOnSelect', () => {