feat: add ref Forwarding to NavDropdown (#4626)

* update table to forwardRef * rearrange props * updates dropdown for ref forward * add displayName * Delete package-lock.json
react-bootstrap · Oct 17, 2019 · be52005 · be52005
1 parent 947e42f
commit be52005
Showing 1 changed file with 24 additions and 24 deletions.
diff --git a/src/NavDropdown.js b/src/NavDropdown.js
@@ -39,9 +39,9 @@ const propTypes = {
   bsPrefix: PropTypes.string,
 };
 
-class NavDropdown extends React.Component {
-  render() {
-    const {
+const NavDropdown = React.forwardRef(
+  (
+    {
       id,
       title,
       children,
@@ -51,29 +51,29 @@ class NavDropdown extends React.Component {
       disabled,
       active,
       ...props
-    } = this.props;
+    },
+    ref,
+  ) => (
+    <Dropdown ref={ref} {...props} as={NavItem}>
+      <Dropdown.Toggle
+        id={id}
+        eventKey={null}
+        active={active}
+        disabled={disabled}
+        childBsPrefix={bsPrefix}
+        as={NavLink}
+      >
+        {title}
+      </Dropdown.Toggle>
 
-    return (
-      <Dropdown {...props} as={NavItem}>
-        <Dropdown.Toggle
-          id={id}
-          eventKey={null}
-          active={active}
-          disabled={disabled}
-          childBsPrefix={bsPrefix}
-          as={NavLink}
-        >
-          {title}
-        </Dropdown.Toggle>
-
-        <Dropdown.Menu role={menuRole} rootCloseEvent={rootCloseEvent}>
-          {children}
-        </Dropdown.Menu>
-      </Dropdown>
-    );
-  }
-}
+      <Dropdown.Menu role={menuRole} rootCloseEvent={rootCloseEvent}>
+        {children}
+      </Dropdown.Menu>
+    </Dropdown>
+  ),
+);
 
+NavDropdown.displayName = 'NavDropdown';
 NavDropdown.propTypes = propTypes;
 NavDropdown.Item = Dropdown.Item;
 NavDropdown.Divider = Dropdown.Divider;