Skip to content

Commit

Permalink
refactor(Col)!: remove default span value in breakpoint object (#6014)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: When using objects in `Col` breakpoint props, `span` is no longer `true` by default
  • Loading branch information
kyletsang committed Sep 21, 2021
1 parent 57be243 commit ec285fb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/Col.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export function useCol({
let order: ColOrder | undefined;

if (typeof propValue === 'object' && propValue != null) {
({ span = true, offset, order } = propValue);
({ span, offset, order } = propValue);
} else {
span = propValue;
}
Expand Down
1 change: 1 addition & 0 deletions www/src/pages/migrating.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Below is a _rough_ account of the breaking API changes as well as the minimal ch
### Col

- `ColOrder` is now maximum 5 instead of 12.
- When using objects in breakpoint props, `span` is no longer `true` by default.

### Dropdown
- dropdown dividers use `hr` by default instead of `div`.
Expand Down

0 comments on commit ec285fb

Please sign in to comment.