How to determine which element ListGroup should output.

[apkiernan]

As mentioned in #1169 continuing discussion here.

Based on the discussion, it sounds like the current thinking is:

• Check the children of ListGroup, and if they are ListGroupItems then we can render as we do currently
• If they are not (user created custom components), then we would fall back to a componentClass prop that the user would specify whether to render <ul> or <div> and render the user specified element.

[taion]

I think that's right. For the latter, div should probably be the default. I think this is the safest way to handle it.

[apkiernan]

For the componentClass prop, I believe everywhere we use this prop its propType is elementType. Should we still use that here? I could see using it for consistency, but <ListGroup> should only be <div> or <ul> so I wonder if React.PropTypes.oneOf(['div', 'ul']) would be more accurate.

[AlexKVal]

I vote for React.PropTypes.oneOf(['div', 'ul']) ❇️

[taion]

Does it make sense to have a custom container component here?

[taion]

I mean a custom React component.

[apkiernan]

I can see using a custom component, but I think making it oneOf(['ul', 'div']) is the right call, as I think we want to ensure that the correct markup is being used.

[taion]

I'm okay with that. It wouldn't be a breaking change to allow custom components down the road anyway.

[taion]

Fixed by #1348.