-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation on <Popover />'s mountNode #157
Comments
Hey @jefffriesen, yeah the popover docs definitely need some work :P, i'm happy to help with your specific case in the mean time if you leave some code of what your trying to do. Generally you wouldn't need to set the container prop as it defaults to body which is usually fine for most cases. These are the docs from the bootstrap site which might be all we need?
|
Thanks for the reply and the offer. I had to get it done so I just used the vanilla-React approach (no library) using getInitialState() and setState to show and hide the Popover component. I may go back to using this library at some point. But as for the documentation, you're right the Bootstrap docs note you added above would be helpful. I still how to retrieve mountNode is a little mysterious, so an example with that would be great. |
This actually is demonstrated in the components demo, though it's broken due to some weirdness. Do we need additional documentation beyond what's there? |
Will add further documentation on |
* moved from mocha to jest * better config options to jest
The container={mountNode} is a bit mysterious in the popover documentation. I see where it's defined in the docs:
But which node it should reference is hard to decipher. I've tried
With no luck (it's still positioned incorrectly). A little bit of documentation of what this node should refer to and how to access it would be really helpful.
The text was updated successfully, but these errors were encountered: