Pass Context.Consumer to context toolbox #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanstitt
force-pushed
the
render-context-consumer-only
branch
2 times, most recently
from
f0caea8
to
ffb8e23
Compare
|
this is the opposite of what's discussed in react-restart/context#9 (comment), no? |
|
Right you are @taion - thanks for noticing and setting me straight. That's what I get for coding on weekend evening. I'll update PR shortly |
As outlined in react-restart/context#9, context toolbox needs to only use only Context, not Context.Consumer
nathanstitt
force-pushed
the
render-context-consumer-only
branch
from
ffb8e23
to
263f073
Compare
jquense
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in react-restart/context#9, context toolbox needs to only use
Context.Consumersince it can't navigate to theConsumerproperty reliably.