Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-bootstrap 1.0.0-beta.3 disabling animation in modal not working #3399

Closed
l1yefeng opened this issue Dec 18, 2018 · 3 comments
Closed
Labels

Comments

@l1yefeng
Copy link

l1yefeng commented Dec 18, 2018

Version and browser:

react-bootstrap@^1.0.0-beta.3
Electron so chrome/chromium (v66)

Usage:

  <Modal animation={false} show={show} onHide={onHide}>
    <Modal.Header closeButton>
      <Modal.Title>
        Some header...
      </Modal.Title>
    </Modal.Header>
    <Modal.Body>
      Some body paragraphs...
    </Modal.Body>
    <Modal.Footer>
      Some buttons ...
    </Modal.Footer>
  </Modal>

Expected

Modal shown when show is set to true no matter animation is set to true or false

But

When animation is not set (default is true), modal is shown properly (btw, animation not so smooth); when false, screen becomes completely black without the modal.

Observation

By looking at developer tools, I see that the div[role=dialog] element which is the parent of the modal div.modal-dialog has style display: none.

@SoulKa
Copy link

SoulKa commented Feb 14, 2019

Can confirm the same behaviour in Firefox with react-bootstrap@^1.0.0-beta.5. It worked fine with react-bootstrap@v0.32.0.

@MichaelBurgess
Copy link

Same behaviour in react-bootstrap@v1.0.0-beta.5 and Chrome Version 73.0.3683.56 (Official Build) beta (64-bit).

@iantbarker
Copy link

Same behavior for me. react-bootstrap@v1.0.0-beta.5 and Firefox and Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants