fix(Modal): set display block always, fixes #3399 #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
reviewed
Mar 26, 2019
src/Modal.js
Outdated
| @@ -340,7 +338,7 @@ class Modal extends React.Component { | |||
| onExiting, | |||
| manager, | |||
| ref: this.setModalRef, | |||
| style: { ...style, ...this.state.style }, | |||
| style: { ...style, display: 'block', ...this.state.style }, | |||
There was a problem hiding this comment.
i think it'd be best to do this only when animation is disabled
taion
approved these changes
Mar 27, 2019
mxschmitt
approved these changes
Apr 11, 2019
|
I still see this issue, my module versions are Thank you |
|
@prakis This change was first included in |
|
@kt3k Thank you. I am testing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started setting
display: blockto div.modal at onEnter timing of Transition at Pull #3187. But when we setanimation={false}to Modal, the Transition object is not created and therefore onEnter (=handleEnter) is not called. This causes empty modal when animation setfalse(I think this is the issue #3399 ). This PR tries to fix this behavior by setting the modal's display style toblockalways.I think this doesn't break existing behavior because as @jquense says
the modal's dom element doesn't exist before rendering. So I think it's safe to set display always
block.