Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active on DropDown.item and NavDropDown.item is not considered a boolean #3598

Closed
HStokbro opened this issue Apr 8, 2019 · 1 comment
Closed

Comments

@HStokbro
Copy link

HStokbro commented Apr 8, 2019

This will result in an error telling you to not use a boolean, but use boolean .toString() instead. But that's just wrong. Active IS a boolean.

const boolean = true;
<Dropdown.Item active={boolean}>
     {text}
</Dropdown.Item>

(Worked fine in beta-5)

@jquense jquense added the bug label Apr 8, 2019
@jquense
Copy link
Member

jquense commented Apr 8, 2019

the active prop is being passed through to the DOM node by accident

mxschmitt added a commit that referenced this issue Apr 10, 2019
* fix: DropDownItem prop-types active prop (fix: #3598)

* fix: if condition

* fix: renamed variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants