Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DropDownItem prop-types active prop (fix: #3598) #3608

Merged
merged 3 commits into from
Apr 10, 2019

Conversation

mxschmitt
Copy link
Member

Fixes #3598.

I hope it's okay, that I simplified these == null and != null statements. (active var type is null|bool and makeEventKey() is null|String)

Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is quite right... we want to treat false differently from null here

taion
taion previously approved these changes Apr 8, 2019
Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good

the one thing i might do naming-wise is – do active: propsActive in destructuring, then call the calculated value active

but that's super nit-picky

@taion
Copy link
Member

taion commented Apr 8, 2019

should we disable the "automatically dismiss reviews" thing? assuming that was an automatic dismissal

@mxschmitt mxschmitt requested a review from jquense April 9, 2019 05:54
@mxschmitt mxschmitt merged commit cf13d90 into master Apr 10, 2019
@mxschmitt mxschmitt deleted the bugfix/DropDownItem/prop-types branch April 10, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants