fix(Collapse): remove 0px menu height on resize and expand/collapse #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
approved these changes
Apr 22, 2019
mxschmitt
approved these changes
Apr 22, 2019
jquense
approved these changes
Apr 23, 2019
jquense
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3394
Found this issue while I was attempting to create a Bootstrap menu without a Navbar.Brand component (I just wanted links). The problem I ran into was when the browser was re-sized to show the collapsed menu and the collapsed menu was expanded, then collapsed and finally the browser was resized to show the full menu, the menu's height was set to 0px.
I have put a full comment in the issue referenced above.