Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion Component Toggling Question #3726

Closed
andrewnystrom opened this issue Apr 30, 2019 · 4 comments · Fixed by #3781
Closed

Accordion Component Toggling Question #3726

andrewnystrom opened this issue Apr 30, 2019 · 4 comments · Fixed by #3781

Comments

@andrewnystrom
Copy link
Contributor

Hello,

I noticed that there doesn't seem to be a way to individually toggle Accordion.Collapse

If I click on the Accordion.Toggle once, the collapse opens as expected. If I click on that same toggle again, nothing happens. My expectation is that the original collapse would close. Is this by design? If not, would you be open to me submitting a PR to introduce this functionality?

Thank you.

@jquense
Copy link
Member

jquense commented May 1, 2019

I think it should probably close if you click again (upstream does this https://getbootstrap.com/docs/4.3/components/collapse/#accordion-example) for more complicated interactions tho the expectation would be to use Collapse directly and manage the state ones self

@andrewnystrom
Copy link
Contributor Author

Yes -- completely agree about the more complicated interactions. I have already identified a solution and will create a PR for review later today. Thanks!

@bpas247
Copy link
Member

bpas247 commented May 14, 2019

Is this issue still up for grabs? I wouldn't mind working on it if it is.

@andrewnystrom
Copy link
Contributor Author

andrewnystrom commented May 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants