fix(AbstractNav): allow passed in refs to be properly forwarded #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
does not currently work, due to various bugs
taion
reviewed
Jul 10, 2019
Co-Authored-By: Jimmy Jia <tesrin@gmail.com>
This comment has been minimized.
This comment has been minimized.
This reduces the complexity of the AbstractNav implementation, especially in regards to how the contexts are integrated with it.
This fixes the assertion issues caused by the selectors testing implementation details to find the DOM elements, rather than testing for something that is gauranteed to be in the implementation (E.g. the class `nav` on the Nav component, since it's part of the Bootstrap design spec) of the rendered DOM element.
Currently, we use a ref to gain access to the underlying component to implement our own functionality. However, this causes an issue with not allowing the user to forward their own ref to gain access to the underlying component. using `useMergedRefs`, we are able to forward both refs to the underlying component.
|
(Just a side-note, we should consider releasing |
13 tasks
bpas247
changed the title
|
no reason, we should probably put it there! |
jquense
approved these changes
Aug 9, 2019
|
i updated this to use restart/hooks; merging so i can cut a release |
|
Thinking we’ll need to update |
|
sure, but we can do that later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract Navshould be forwarding its ref to the underlying component, so thatNav(and any other components using this) can get the proper ref.Fixes #4012.