Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AbstractNav): allow passed in refs to be properly forwarded #4031

Merged
merged 8 commits into from Aug 9, 2019

Commits on Jul 10, 2019

  1. fix: first pathrough of migration to AbstractNav forwarding ref

    does not currently work, due to various bugs
    bpas247 committed Jul 10, 2019
    Copy the full SHA
    5f13a0a View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    d4e0ac3 View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from code review

    Co-Authored-By: Jimmy Jia <tesrin@gmail.com>
    bpas247 and taion committed Jul 10, 2019
    Copy the full SHA
    479870c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2019

  1. Migrate AbstractNav implementation to use hooks in replace of HOC

    This reduces the complexity of the AbstractNav implementation,
    especially in regards to how the contexts are integrated with it.
    bpas247 committed Jul 27, 2019
    Copy the full SHA
    a7c7a80 View commit details
    Browse the repository at this point in the history
  2. fix: Nav and TabContainer selectors not finding the right element

    This fixes the assertion issues caused by the selectors testing
    implementation details to find the DOM elements, rather than
    testing for something that is gauranteed to be in the
    implementation (E.g. the class `nav` on the Nav component, since
    it's part of the Bootstrap design spec) of the rendered DOM
    element.
    bpas247 committed Jul 27, 2019
    Copy the full SHA
    bf5cbc1 View commit details
    Browse the repository at this point in the history
  3. fix: AbstractNav not properly merging both of its refs

    Currently, we use a ref to gain access to the underlying
    component to implement our own functionality. However, this causes
    an issue with not allowing the user to forward their own ref
    to gain access to the underlying component. using `useMergedRefs`,
    we are able to forward both refs to the underlying component.
    bpas247 committed Jul 27, 2019
    Copy the full SHA
    088d147 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Copy the full SHA
    9307048 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ef19da6 View commit details
    Browse the repository at this point in the history