Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel slide navigation direction on swipe is incorrect #4136

Closed
RageJS opened this issue Jul 28, 2019 · 0 comments
Closed

Carousel slide navigation direction on swipe is incorrect #4136

RageJS opened this issue Jul 28, 2019 · 0 comments

Comments

@RageJS
Copy link
Contributor

RageJS commented Jul 28, 2019

Describe the bug

React-bootstrap beta 10 version added touch support in Carousel Component, but the direction of slide navigation is right on right swipe and left on left swipe.

To Reproduce

  1. Go to https://react-bootstrap.github.io/components/carousel/ on mobile or tablet or other touch device.
  2. Try Swiping on the demo slides.

Expected behavior

The carousel should navigate to previous slide on right swipe and next slide on left swipe.

Environment (please complete the following information)

  • Operating System: MacOS
  • Browser Version: Chrome 73
  • React-Bootstrap: Version 1.0.0-beta.10
RageJS added a commit to RageJS/react-bootstrap that referenced this issue Jul 28, 2019
@RageJS
fix(Carousel): fixes react-bootstrap#4136 - reverse carousel slide na…
d851e52 
…vigation direction for touch
RageJS added a commit to RageJS/react-bootstrap that referenced this issue Jul 28, 2019
@RageJS
Merge pull request #1 from RageJS/fix/carousel-touch-slide-direction
7cba01c 
fix(Carousel): fixes react-bootstrap#4136 - reverse carousel slide navigation direction for touch
@RageJS RageJS mentioned this issue Jul 28, 2019
Merged
RageJS added a commit to RageJS/react-bootstrap that referenced this issue Jul 28, 2019
@RageJS
chore(carousel-spec): correct formatting react-bootstrap#4136
301df62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RageJS