Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): directly show backdrop if no animation (fix: #4190) #4192

Merged
merged 4 commits into from
Aug 6, 2019
Merged

fix(Modal): directly show backdrop if no animation (fix: #4190) #4192

merged 4 commits into from
Aug 6, 2019

Conversation

mxschmitt
Copy link
Member

jquense
jquense reviewed Aug 6, 2019
View reviewed changes
src/Modal.js Outdated Show resolved Hide resolved
www/src/pages/components/modal.js Outdated Show resolved Hide resolved
mxschmitt and others added 2 commits August 6, 2019 15:03
@mxschmitt
Update Modal.js
92ca92f
@mxschmitt @jquense
Update www/src/pages/components/modal.js
ddc8b1e 
Co-Authored-By: Jason Quense <monastic.panic@gmail.com>
@mxschmitt mxschmitt requested a review from jquense August 6, 2019 13:04
@mxschmitt mxschmitt merged commit 0d02bf6 into master Aug 6, 2019
@mxschmitt mxschmitt deleted the bugfix/4190 branch August 6, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

@taion taion taion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mxschmitt @jquense @taion