Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support actional bagdes by adding the as property to the Badge component #4227

Closed
simzikov opened this issue Aug 9, 2019 · 1 comment · Fixed by #4295
Closed

Support actional bagdes by adding the as property to the Badge component #4227

simzikov opened this issue Aug 9, 2019 · 1 comment · Fixed by #4295
Labels
enhancement PR welcome

Comments

@simzikov
Copy link

simzikov commented Aug 9, 2019 •
edited
Loading

According to Bootstrap, we can turn simple badges to actionable badges by using them with an a tag: https://getbootstrap.com/docs/4.3/components/badge/#links. Currently, the badge component lacks the as prop. Would be great to have it.
@taion
Copy link
Member

taion commented Aug 10, 2019

We'd be happy to take a PR for this.

@mcmxcdev mcmxcdev mentioned this issue Aug 21, 2019
Merged
taion pushed a commit that referenced this issue Aug 22, 2019
@taion
feat: Add the as prop to Badge to support actionable badges (#4295)
db09dc0 
* feat: support actional bagdes by adding the as property to the Badge component (#4227)

* add 'as' prop to Badge.js

* add unit test that verifies 'as' prop is working

Signed-off-by: mhatvan <markus_hatvan@aon.at>

* * updated type definitions & simple.test.tsx for Badge

Signed-off-by: mhatvan <markus_hatvan@aon.at>

* feat: added another TS test case

* fix: closing tag

* fix: prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement PR welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add the as prop to Badge to support actionable badges
3 participants
@taion @mxschmitt @simzikov