Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Toast component #4246

Merged
merged 2 commits into from
Aug 14, 2019
Merged

fix(types): Toast component #4246

merged 2 commits into from
Aug 14, 2019

Conversation

mxschmitt
Copy link
Member

I don't know how to fix this, but that's at least the test for it.
Would be cool if someone could help me :)

@taion
Copy link
Member

taion commented Aug 13, 2019

show and transition aren't marked optional in

show: boolean;
transition: boolean | React.ElementType;

Is that intentional? That's the error you're seeing.

@mxschmitt
Copy link
Member Author

mxschmitt commented Aug 13, 2019

show and transition aren't marked optional in

show: boolean;
transition: boolean | React.ElementType;

Is that intentional? That's the error you're seeing.

I don't think so, because we provide defaultProps there. So true for show and Fade for transition. I've adjusted it.

And thanks @taion!

@mxschmitt mxschmitt merged commit c30e131 into master Aug 14, 2019
@mxschmitt mxschmitt deleted the bugfix/Toast branch August 28, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants