Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add the as prop to Badge to support actionable badges #4295

Merged
merged 5 commits into from
Aug 22, 2019
Merged

feat: Add the as prop to Badge to support actionable badges #4295

merged 5 commits into from
Aug 22, 2019

Conversation

mcmxcdev
Copy link

Fixes #4227

feat: support actional bagdes by adding the as property to the Badge …
3851f47 
…component (#4227)

* add 'as' prop to Badge.js

* add unit test that verifies 'as' prop is working

Signed-off-by: mhatvan <markus_hatvan@aon.at>
@taion taion changed the title feat: support actional bagdes by adding the as property to the Badge component feat: Add the as prop to Badge to support actionable badges Aug 21, 2019
taion
taion reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine, but add this to the TypeScript def as well

taion
taion reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine, but add this to the TypeScript def as well

* updated type definitions & simple.test.tsx for Badge
431a621 
Signed-off-by: mhatvan <markus_hatvan@aon.at>
@mcmxcdev
Copy link
Author

mcmxcdev commented Aug 21, 2019 •
edited
Loading

fine, but add this to the TypeScript def as well

@taion unsure about how they should look like, but I added another commit trying ;)

@taion taion merged commit db09dc0 into react-bootstrap:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taion taion taion approved these changes

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support actional bagdes by adding the as property to the Badge component
3 participants
@mcmxcdev @taion @mxschmitt