Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar toggle correct 'collapsed' className when collapsed #4412

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Navbar toggle correct 'collapsed' className when collapsed #4412

merged 2 commits into from
Sep 5, 2019

Conversation

mattywong
Copy link
Contributor

This pr fixes #4399

taion
taion approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the tests then this is gtg

@jquense jquense merged commit bcb0c8e into react-bootstrap:master Sep 5, 2019
@jquense
Copy link
Member

jquense commented Sep 5, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

@taion taion taion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navbar.Toggle component adds wrong 'collapsed' className depending on expanded context state
3 participants
@mattywong @jquense @taion