Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ref Forwarding to NavDropdown #4626

Merged
merged 6 commits into from
Oct 17, 2019
Merged

Add ref Forwarding to NavDropdown #4626

merged 6 commits into from
Oct 17, 2019

Conversation

DoctorHowser
Copy link
Contributor

Adds in ref forwarding for NavDropdown per
#4194

jquense
jquense requested changes Oct 9, 2019
View reviewed changes
src/NavDropdown.js Show resolved Hide resolved
@DoctorHowser
Copy link
Contributor Author

DoctorHowser commented Oct 10, 2019 •
edited
Loading

displayName added

@taion
Copy link
Member

taion commented Oct 10, 2019

please remove the package-lock.json as well; this repo uses yarn

@DoctorHowser
Copy link
Contributor Author

Doh. I was being so careful. Will do.

@bpas247 bpas247 mentioned this pull request Oct 16, 2019
Closed
13 tasks
@jquense jquense merged commit be52005 into react-bootstrap:master Oct 17, 2019
@jquense
Copy link
Member

jquense commented Oct 17, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

@taion taion taion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DoctorHowser @taion @jquense