Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing constants after ES6 migration #478

Closed
mtscout6 opened this issue Apr 4, 2015 · 3 comments
Closed

Missing constants after ES6 migration #478

mtscout6 opened this issue Apr 4, 2015 · 3 comments
Assignees
@mtscout6
Labels
bug

Comments

@mtscout6
Copy link
Member

mtscout6 commented Apr 4, 2015

@trevorr You are correct that constants is now missing from the public api, I missed that when I was transitioning to ES6.

First reported in #306
@mtscout6 mtscout6 added the bug label Apr 4, 2015
@mtscout6 mtscout6 self-assigned this Apr 4, 2015
@mtscout6
Copy link
Member Author

mtscout6 commented Apr 4, 2015

Release in 0.20.1! Thanks for reporting this @trevorr.

@trevorr
Copy link

trevorr commented Apr 6, 2015

@mtscout6 Thanks for the quick response. However, doesn't exposing the constants in this way lead to the problem I mentioned in #306, where the accepted styles can't effectively be changed after the rest of the library is initialized. I can now access the constants, but adding custom styles doesn't prevent the warnings.

@mtscout6 mtscout6 mentioned this issue Apr 6, 2015
Closed
@mtscout6
Copy link
Member Author

mtscout6 commented Apr 6, 2015

@trevorr You are correct that that is a problem and one that needs to be addressed. Can we follow up on this discussion in #440?

aryad14 pushed a commit to aryad14/react-bootstrap that referenced this issue Oct 11, 2023
@greenkeeper @ad1992
chore(package): Update prettier to the latest version 🚀 (react-bootst…
6f52ed7 
…rap#478)

* chore(package): update prettier to version 1.16.2

* chore(package): update lockfile package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtscout6 mtscout6

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtscout6 @trevorr