Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form.Label does not have size prop #4886

Closed
raghavi92 opened this issue Dec 12, 2019 · 2 comments
Closed

Form.Label does not have size prop #4886

raghavi92 opened this issue Dec 12, 2019 · 2 comments
Labels
difficulty: easy PR welcome

Comments

@raghavi92
Copy link
Contributor

Describe the bug

I would like to set the size for Form.Control and its corresponding Form.Label components.
While its working as expected for Form.Control prop, Form.Label component does not have a similar size prop.

Reproducible Example

Minimal example by using CodeSandbox.

Expected behavior

The size of the label should be applied accordingly.

Environment (please complete the following information)

  • Operating System: [Ubuntu]
  • Browser, Version [Chrome 78]
  • React-Bootstrap Version [1.0.0-beta.16]
@taion
Copy link
Member

taion commented Dec 12, 2019

The column prop for Form.Label should probably take a size per https://getbootstrap.com/docs/4.3/components/forms/#horizontal-form-label-sizing.

We'd be happy to take a PR for this.

@raghavi92
Copy link
Contributor Author

Thank you. I'll make a PR

adamayres added a commit to lithiumtech/react-bootstrap that referenced this issue Feb 5, 2020
@adamayres
Merge branch 'master' into classNameMapSupport
43b051c 
* master: (54 commits)
  docs: Add Glyphicon removal to "Migrating to v1" doc (react-bootstrap#4967)
  chore(deps): update all non-major dependencies (react-bootstrap#4964)
  docs: fixed typos (react-bootstrap#4957)
  refactor(OverlayTrigger): convert to function component (react-bootstrap#4938)
  Add missing horizontal in ListGroupProps (react-bootstrap#4864)
  chore(deps): update all non-major dependencies (react-bootstrap#4953)
  chore(deps): update dependency cross-env to v7 (react-bootstrap#4949)
  Label large dropdown as large in playground (react-bootstrap#4945)
  Fix typographical errors in Button docs (react-bootstrap#4943)
  docs: fix dropdown typos (react-bootstrap#4944)
  docs: Fix component spacing in examples (react-bootstrap#4914)
  chore(deps): update all non-major dependencies (react-bootstrap#4941)
  chore(deps): update dependency lint-staged to v10 (react-bootstrap#4942)
  react-bootstrap#4884 add responsive containers (react-bootstrap#4902)
  feat: add size prop for FormLabel component - Fixes react-bootstrap#4886 (react-bootstrap#4893)
  tests: added for Modal and OverlayTrigger (react-bootstrap#4931)
  test: increase test coverage with minor refactor (react-bootstrap#4922)
  chore(deps): update all non-major dependencies (react-bootstrap#4929)
  docs: fix element type used for Breadcrumb (react-bootstrap#4926)
  chore(deps): update dependency husky to v4 (react-bootstrap#4923)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@taion @raghavi92 @mxschmitt