Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot pass microdata attribute to Breadcrumb.Item #5054

Closed
agrawalj opened this issue Mar 20, 2020 · 0 comments · Fixed by #5055
Closed

Cannot pass microdata attribute to Breadcrumb.Item #5054

agrawalj opened this issue Mar 20, 2020 · 0 comments · Fixed by #5055
Assignees
@mxschmitt
Labels
enhancement

Comments

@agrawalj
Copy link

To add schema microdata to breadcrumb, there is a option to pass custom attributes to <ol> via Breadcrumb & listProps but, there is no option to pass custom attributes to <li> via Breadcrumb.Item
@mxschmitt mxschmitt self-assigned this Mar 20, 2020
mxschmitt added a commit that referenced this issue Mar 20, 2020
@mxschmitt
feat(BreadcrumbItem): pass props to li element
13f002e 
Closes #5054
@mxschmitt mxschmitt mentioned this issue Mar 20, 2020
Merged
taion added a commit that referenced this issue Mar 23, 2020
@mxschmitt @taion
feat(BreadcrumbItem): pass props to li element (#5055)
eb4877f 
* feat(BreadcrumbItem): pass props to li element
Closes #5054

* fix: linting

* fix: adjustments to property handling

* Update src/BreadcrumbItem.js

Co-Authored-By: Jimmy Jia <tesrin@gmail.com>

* feat: applied review changes

* fix: prettier

* fix: linting

* fix: Prettier finally after upgrade

Co-authored-by: Jimmy Jia <tesrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxschmitt mxschmitt

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(BreadcrumbItem): pass props to li element react-bootstrap/react-bootstrap
2 participants
@mxschmitt @agrawalj