fix(Toast): Reset autohide timer only if show or autohide changed #5220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
approved these changes
Jun 6, 2020
Co-authored-by: Jimmy Jia <tesrin@gmail.com>
taion
approved these changes
Jun 6, 2020
taion
reviewed
Jun 6, 2020
taion
approved these changes
Jun 7, 2020
brianackley001
added a commit
to brianackley001/budgeting-app-client
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5173.
The autohide timer was being reset on every render, so I changed it only to reset if
showorautohideis changed. I noticed there was a note about not restarting the timer ifdelayis changed so I left that as is.