Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Badge> doesn't accept multiple text segments #532

Closed
glenjamin opened this issue Apr 17, 2015 · 3 comments
Closed

<Badge> doesn't accept multiple text segments #532

glenjamin opened this issue Apr 17, 2015 · 3 comments

Comments

@glenjamin
Copy link
Collaborator

This is possibly a slightly unusual use-case, but the behaviour is still surprising.

<Badge>£10</Badge>

Probably similar to #296

@mtscout6
Copy link
Member

That's an unfortunate bug. Can you submit a PR with some tests for this use case?

@AlexKVal
Copy link
Member

My two cents into it:

That way

React.createElement(Badge, null, "£10")

it's working.

In my trash project which using browserify

<Badge>£10</Badge>

it is also working.

But if I put jsx version straight into docs/examples/Badge.js and then

npm run docs
open http://localhost:4000

it doesn't render.

I'll check the state of the issue after I'm finished that I'm already working with,
and if it has no progress yet, I'll try to fix it.

@glenjamin
Copy link
Collaborator Author

Eugh, sorry, I screwed up my example. This is the actual failing case (renders empty).

<Badge>{num}</Badge>

I'll do a PR with tests and a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants