Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v5): Set ColOrder types to max 5 #5376

Merged
merged 2 commits into from
Aug 12, 2020
Merged

feat(v5): Set ColOrder types to max 5 #5376

merged 2 commits into from
Aug 12, 2020

Conversation

kyletsang
Copy link
Member

https://v5.getbootstrap.com/docs/5.0/migration/#utilities

Decreased the number of responsive order utilities per breakpoint. The highest order utility with a number now is .order-5 instead of .order-12.

This PR just changes the TS types to restrict string numbers to max 5

@kyletsang kyletsang added this to In Progress in v5 support via automation Aug 11, 2020
@taion
Copy link
Member

taion commented Aug 11, 2020

perhaps we want another type alias for the valid order values?

@kyletsang
Copy link
Member Author

perhaps we want another type alias for the valid order values?

Not sure I understand. Something in addition to ColOrder?

@taion
Copy link
Member

taion commented Aug 11, 2020

i mean something like NumberAttr

@kyletsang kyletsang merged commit 926c7cf into bs5-dev Aug 12, 2020
v5 support automation moved this from In Progress to Done Aug 12, 2020
@kyletsang kyletsang deleted the v5-col-order branch August 12, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taion taion taion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v5 support
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyletsang @taion